Adding a rotary encoder to a hacked servo

Did this work?

Hello I’m working on a similar project ans was wondering if it worked? No mechanical issues since this is a mechanical encoder??